search

dilevin / computer-graphics-ray-tracing

Computer Graphics Assignment about Ray Tracing
1 stars 5 forks source link

Light position is different #40

Closed RaihanFaruque closed 4 years ago

RaihanFaruque commented 4 years ago

This is the image I get Screenshot from 2020-01-30 19-15-01 In my image, the specular highlights are at different place compared to the reference image. What is causing this issue?

RaihanFaruque commented 4 years ago

same thing happens here Screenshot from 2020-01-30 19-59-21

darren-moore commented 4 years ago

I'd guess one of the directional light or point light directions you return are incorrect. https://github.com/dilevin/computer-graphics-ray-tracing/issues/25 or https://github.com/dilevin/computer-graphics-ray-tracing/issues/29 may help

RaihanFaruque commented 4 years ago

Ah forgot to normalize the ray direction