search

dilevin / computer-graphics-ray-tracing

Computer Graphics Assignment about Ray Tracing
1 stars 5 forks source link

Weird Self-reflection #68

Open dorsa01 opened 6 days ago

dorsa01 commented 6 days ago

The output for my sphere-and-plane looks like as follows, and it has some self-reflections and weird shadowing at some parts, and some part of the sphere is very bright. I added the fudge factors for reflection and shadow rays. When I set the max_num_reflections to 1, I get the second image where still some part of the sphere is bright. Where may the problem be? Thank you rgb (7) rgb (8)

vpineda1996 commented 6 days ago

Have you tried https://github.com/dilevin/computer-graphics-ray-tracing/issues/52?

dorsa01 commented 6 days ago

yes, I checked it and min_t has been set correctly. Anywhere else in the code that you think I need to check?

Thank you

vpineda1996 commented 6 days ago

I would double check your implementation of ray reflection as it seems that the reflecting ray might is probably not pointing in the right direction.

dorsa01 commented 4 days ago

I checked my reflections and I am following the tutorial slides. Also I get the same output as ambient-diffuse-specular-shadows.png when I set the max recursion to 0. Any other suggestion?