dilevin / computer-graphics-ray-tracing

Computer Graphics Assignment about Ray Tracing
1 stars 5 forks source link

Light Spots Inconsistency #74

Closed Vesnushkin closed 1 month ago

Vesnushkin commented 1 month ago

Hey!

It seems like everything is quite okay, however the two light dots (one each ball) seem to be closer together than they need to be:

Screenshot 2024-09-27 at 9 09 52 PM

^ Mine ^ sphere-packing ^ Provided picture ^

I'm not sure what the issue is, I've been trying to edit my implementations but it doesn't seem to resolve it. Any insights?

vpineda1996 commented 1 month ago

You can try using imagemagick CLI to find more debugging info. If your picture is off by just a few pixels we won't penalize you for it.

Vesnushkin commented 1 month ago

I was able to fix this issue by properly calculating the $H$ vector! (I needed to put a negative sign on on a vector, and properly normalize all the components).