dilevin / computer-graphics-shader-pipeline

Computer Graphics Assignment about the Shader Pipeline
2 stars 5 forks source link

Confused about model vs model_view_projection #47

Open RudainaK opened 8 months ago

RudainaK commented 8 months ago

In model, we are asked to return the transformation matrix (expected things include translate and rotate_about_y) but the values needed (theta, amount to translate, scaling factor) are in model_view_projection, but we can't pass the parameters needed. Do we write model based off of the comments in model_view_projection?

wenzhi-guo commented 8 months ago

Yes, your understanding is correct.

RudainaK commented 8 months ago

should the scaling be done in model or model_view_projection? neither one expects uniform_scale so does it just not matter where we do it?

wenzhi-guo commented 8 months ago

Better to do it in model since it constructs the transformation matrix.