dillingham / nova-attach-many

BelongsToMany create / edit form component for Nova
MIT License
271 stars 107 forks source link

Is Nova 4 support planned? #101

Closed ziming closed 2 years ago

ziming commented 2 years ago

Like to ask if there are plans to support Nova 4, if not then I will try to find some alternatives. Thanks!

anditsung commented 2 years ago

hi, i already create a PR for this.

bashgeek commented 2 years ago

Seems like this is kind of abandoned for now. If anybody is looking for a working Nova 4 version, here is our fork with this PR applied and used in production by us already: https://github.com/blendbyte/nova-attach-many

ziming commented 2 years ago

@dillingham it would be great if you can merge the PR!

https://github.com/dillingham/nova-attach-many/pull/100

dillingham commented 2 years ago

Going to work on merging that pr soon

alekmlynek commented 2 years ago

Any luck on the PR?

alies-dev commented 2 years ago

any news, guys?

abdulwahid commented 2 years ago

@dillingham As you have already merged the PR https://github.com/dillingham/nova-attach-many/pull/100 into master. Are you planning to create a new release for this?

alies-dev commented 2 years ago

Hey @dillingham Can you please release a new major version of the package (with Nova v4 support)?

roblegaspi commented 2 years ago

+1

NoahNxT commented 2 years ago

@dillingham Please create a new release for it!

ziming commented 2 years ago

@dillingham you may have forgotten to tag a release after you merged this PR to support nova 4

vesper8 commented 2 years ago

You must use dev-master for now.

Also, a duplicate use declaration causes fatal error. I created a PR https://github.com/dillingham/nova-attach-many/pull/106

dillingham commented 2 years ago

tagged a 2.0 release

vesper8 commented 2 years ago

Awesome @dillingham !

I also just noticed that the Tailwind styles aren't all working in Nova 4, making your custom field look very.. unstyled.

I've created a PR which also explains why this happened: https://github.com/dillingham/nova-attach-many/pull/107

Cheers!