search

dillongoh / pe

0 stars 0 forks source link

Allows adding projects with invalid dates. #10

Open dillongoh opened 1 year ago

dillongoh commented 1 year ago

After entering the command "ap n/test123ads d/+++2" it produced this :

image.png

nus-se-bot commented 1 year ago

Team's Response

This stems from the same issue since the validation for the deadlines is handled by the same library, since it would be difficult to validate both fixed date-time formats and natural language formats. A valid input is defined as anything that the library would be able to parse a date-time from. The library is able to parse 2 am out of the 2 in the input string.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unexpected time to autofill

Entering the command "ap n/test6 d/15-04-2023" gives me the following output:

image.png

The program has added a deadline timing of 3am which does not make sense to me as the user. Even if a time was to be displayed, I would expect midnight to be the default time.

[original: nus-cs2103-AY2223S2/pe-interim#1142] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The current expected behaviour is that the app parses all deadline inputs into a date-time output due to the library used to parse natural language/date formats. If no time is provided by the user, the current time is taken as the time to use.

Due to the usage of a library, it would take a lot more effort to remove the time of the output if no time is provided by the user. The user can also edit the deadline to have a 12am time if needed.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This issue is not a duplicate of the original bug. The original bug is about the unexpected default timing when no time is provided. This bug is about the deadline "+++2" being interpreted as "April 14 2023 2am".

## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** This bug should not be NotInScope. Accurate date parsing should not be unprioritized in a project management app
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** This is not an incomplete or missing feature but an unexpected behavior with their existing feature that they claim to have. (Storing of date and time for deadlines)