search

dillongoh / pe

0 stars 0 forks source link

Allows phone numbers that are too long. #3

Open dillongoh opened 1 year ago

dillongoh commented 1 year ago

The longest valid phone number is 15 digits long. There is a restriction placed on phone numbers that are too short. But there are no restrictions for phone numbers that are too long, allowing the user to store invalid phone numbers.

image.png

nus-se-bot commented 1 year ago

Team's Response

Same example provided of too long phone number.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

It is allowed to input a phone number consisting of lots of digits

I admit it is hard to fix the length of phone number as length of number is different in different countries, but I feel there should at least be a upper limit.

Currently, it is possible to input a phone number that is extremely long, as shown in the following picture -

image.png

Steps to reproduce -

  1. Input ac name/Panav phone/12345678123456781234567812345678123456781234567812345678........

[original: nus-cs2103-AY2223S2/pe-interim#3812] [original labels: severity.VeryLow type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** This is not a cosmetic problem and should not be of VeryLow severity.