dillongoostudios / goo-engine

Custom build of blender with some extra NPR features.
Other
973 stars 127 forks source link

Add non-uniform scaling controls for Curvature node #8

Closed festivities closed 1 year ago

festivities commented 1 year ago

The Curvature node/depth-based rim lighting is something I've always wanted in Blender. That day has come and I'm very grateful for this project! However there's still one thing missing for me and those are non-uniform scaling controls. I decided to add them myself. I hope this pull request gets accepted, or rather the general feature is implemented.

Thank you!

https://user-images.githubusercontent.com/77230051/200498459-2ba1d48c-cab1-4447-9144-adee200169b0.mp4

https://user-images.githubusercontent.com/77230051/200498800-e4cce666-25de-4fbd-9f39-968df4d5dd28.mp4

Lateasusual commented 1 year ago

This is good and could be useful! I think to avoid confusion it'd be better to use something other than "Thickness" since that has a different meaning here (the rim edge detection thickness). I like the idea of keeping the main scale and having separate inputs for the non-uniform X/Y, but in that case i'd probably prefer if the non-uniform scale factor was a vector instead :)

So maybe just having a "Scale" vector socket separate to radius would probably do the job

festivities commented 1 year ago

Thank you for the feedback. I've made the corresponding changes and here's a video included. Hopefully I'm not wrong but I believe 2D vector sockets aren't supported in Blender yet? For now, I've set the value of the third element to 0.0 to imply that it's not meant to be used.

https://user-images.githubusercontent.com/77230051/201300594-dc0978d9-5652-4e6d-955b-03e6b55e7ba4.mp4

Lateasusual commented 1 year ago

Sorry I've been pretty busy, I'm away at the moment but I'll test this once I get home and merge it :3

festivities commented 1 year ago

Hey, I hope you don't mind me bumping this pull request 😅 I wish to ask for a follow-up since it's been a month or so since the last reply on this thread. Been waiting to see if I could get some closure on this.

Lateasusual commented 1 year ago

Sorry for the long wait, just wanted to wait until we were in between productions before updating everything :)