In prog: harris_sch4_1pp3c compute unit: hcompute_cim_stencil has a mismatch between C++ and coreir

dillonhuff commented 3 years ago

@jeffsetter @rdaly525 I'm guessing this is related to #108 but there is an error in one of the Harris sch4 compute units:

ERROR in compute unit: hcompute_cim_stencil
in0_lgxx_stencil[0] -> 18547
in0_lgxx_stencil[0] -> 0100100001110011
in1_lgxy_stencil[0] -> 56401
in1_lgxy_stencil[0] -> 1101110001010001
in2_lgyy_stencil[0] -> 23807
in2_lgyy_stencil[0] -> 0101110011111111
    coreir_result: 18585
    cpp_result   : 22681

Could you take a look at this?

Testbench is here: https://github.com/dillonhuff/clockwork/tree/master/compute_unit_regressions/harris_sch4_1pp3c/hcompute_cim_stencil

jeffsetter commented 3 years ago

Can confirm. After modifying "wire" to "wire signed", it passes.

rdaly525 commented 3 years ago

Sorry, just saw this. Ill take a look.

dillonhuff / clockwork

In prog: harris_sch4_1pp3c compute unit: hcompute_cim_stencil has a mismatch between C++ and coreir #112