In prog: unsharp compute unit: hcompute_ratio_stencil has a mismatch between C++ and coreir

dillonhuff / clockwork

A polyhedral compiler for hardware accelerators

53 stars 11 forks source link

In prog: unsharp compute unit: hcompute_ratio_stencil has a mismatch between C++ and coreir #118

Open dillonhuff opened 3 years ago

dillonhuff commented 3 years ago

@jeffsetter now unsharp has an error in its compute units:

ERROR in compute unit: hcompute_ratio_stencil
in0_blur_unnormalized_stencil[0] -> 63743
in0_blur_unnormalized_stencil[0] -> 1111100011111111
in1_gray_stencil[0] -> 2
in1_gray_stencil[0] -> 0000000000000010
    coreir_result: 255
    cpp_result   : 192

jeffsetter commented 3 years ago

This is another instance where the shift is not behaving the same in coreir and the cpu. Similar to this: https://github.com/dillonhuff/clockwork/issues/108