Closed hariroshan closed 2 years ago
Hi @hariroshan, thank you for the PR! There are some failing tests (see the GitHub action). Could you fix those, and also add a few unit tests to make sure we have good coverage around cases where hashes are used?
Hi @hariroshan, thanks for fixing the unit tests in DocumentTests.elm
.
Could you also add some additional unit test cases in that file that show the cases where hashes are still used to make sure those are working properly (and continue to work properly with any future changes)? Besides that, this is looking good to merge 👍
Can you check for any changes or additions?
This is now live with Elm package version 5.0.10. Thank you so much for your work on this @hariroshan, I really appreciate it! 🙏
https://github.com/dillonkearns/elm-graphql/blob/master/CHANGELOG-ELM-PACKAGE.md#5010---2022-06-20
@dillonkearns Pleasure is mine. Thank you for maintaining this awesome package. Also do u have any idea on how we can implement persistent queries?. I'd like to contribute if you know how we can achieve this
Regarding Feedback I've made the changes to serialisation and decoding of GraphQL queries. Review and Merge accordingly 😄