search

dillonkearns / elm-graphql

Autogenerate type-safe GraphQL queries in Elm.
https://package.elm-lang.org/packages/dillonkearns/elm-graphql/latest
BSD 3-Clause "New" or "Revised" License
778 stars 107 forks source link

Better serialization on graphql queries and refactoring #596

Closed hariroshan closed 2 years ago

hariroshan commented 2 years ago

Regarding Feedback I've made the changes to serialisation and decoding of GraphQL queries. Review and Merge accordingly 😄

dillonkearns commented 2 years ago

Hi @hariroshan, thank you for the PR! There are some failing tests (see the GitHub action). Could you fix those, and also add a few unit tests to make sure we have good coverage around cases where hashes are used?

dillonkearns commented 2 years ago

Hi @hariroshan, thanks for fixing the unit tests in DocumentTests.elm.

Could you also add some additional unit test cases in that file that show the cases where hashes are still used to make sure those are working properly (and continue to work properly with any future changes)? Besides that, this is looking good to merge 👍

hariroshan commented 2 years ago

Can you check for any changes or additions?

dillonkearns commented 2 years ago

This is now live with Elm package version 5.0.10. Thank you so much for your work on this @hariroshan, I really appreciate it! 🙏

https://github.com/dillonkearns/elm-graphql/blob/master/CHANGELOG-ELM-PACKAGE.md#5010---2022-06-20

hariroshan commented 2 years ago

@dillonkearns Pleasure is mine. Thank you for maintaining this awesome package. Also do u have any idea on how we can implement persistent queries?. I'd like to contribute if you know how we can achieve this