dillonkearns / elm-graphql

Autogenerate type-safe GraphQL queries in Elm.
https://package.elm-lang.org/packages/dillonkearns/elm-graphql/latest
BSD 3-Clause "New" or "Revised" License
778 stars 107 forks source link

Add json serialization #605

Closed SiriusStarr closed 1 year ago

SiriusStarr commented 2 years ago

Fixes #570

Per conversation on slack...

Somebody with a much more thorough understanding of Graphql should review this thoroughly to make certain there aren't unforeseen consequences, but it works for me without issue with the API I was working with that required JSON scalar input.

dillonkearns commented 2 years ago

This is looking great!

I think this is good to merge. I'll just play around with a few examples to do a final sanity check and then release this. Thanks for the PR!

It also makes me think of one longer term thing for a future change, which I've documented in #606.

dillonkearns commented 1 year ago

This is now released here: https://github.com/dillonkearns/elm-graphql/blob/master/CHANGELOG-ELM-PACKAGE.md#5011---2022-09-14. Thanks again for the PR @SiriusStarr!