search

dillonkearns / elm-pages

Hybrid Elm framework with full-stack and static routes.
https://elm-pages.com
BSD 3-Clause "New" or "Revised" License
658 stars 97 forks source link

Port to elm-codegen 5.0.0 #488

Closed miniBill closed 2 months ago

netlify[bot] commented 3 months ago

Deploy Preview for elm-pages-todos ready!

Name Link
Latest commit b282003f54958b33bc5fcc86731bb92800fa857c
Latest deploy log https://app.netlify.com/sites/elm-pages-todos/deploys/66f35dad75ef200008e86117
Deploy Preview https://deploy-preview-488--elm-pages-todos.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dillonkearns commented 3 months ago

Thank you for the PR! Looks like there is still some code that isn't compiling from those build failures?

miniBill commented 3 months ago

I will look into it!

miniBill commented 2 months ago

I'm having an issue with Scaffold.Route > userFunction > viewFn, in the Nothing case.

You're currently wrapping it. In the call field it seems the objective is to ignore what (in the Just branch) is the Model. But then in callFrom you ignore a different parameter, so I'm confused.

EDIT: figured out how to do it with the new API

miniBill commented 2 months ago

(Force pushed to force the CI to run again, as it had a transient error)