search

dillonkearns / elm-pages

Hybrid Elm framework with full-stack and static routes.
https://elm-pages.com
BSD 3-Clause "New" or "Revised" License
658 stars 97 forks source link

Move elm-codegen to be a test dependency #489

Closed miniBill closed 1 month ago

miniBill commented 1 month ago

I realized that elm-codegen is not actually used by elm-pages-the-library, so it can be moved to be a test dependency

netlify[bot] commented 1 month ago

Deploy request for elm-pages-todos pending review.

Visit the deploys page to approve it

Name Link
Latest commit a0e2cb119742d106c73e9be2a001440cfbb0f19f
miniBill commented 1 month ago

Uh, the modules that are using elm-codegen seem to be only used by scripts for scaffolding. Which. Makes sense. Unfortunately this PR is not possible to merge as-is.

Splitting off the parts that depend on elm-codegen is probably not worth doing.

miniBill commented 1 month ago

(If splitting, I still think it would make sense to split the "script" and "view" parts, but I remember you saying that you think it would introduce an additional burden on users and is not worth it considering that DCE anyway)