search

dillonkearns / mobster

Pair and mob programming timer for Mac, Windows, and Linux.
http://mobster.cc
MIT License
308 stars 39 forks source link

Setting the shortcut key to a non-ascii crashes the app #48

Closed DevL closed 7 years ago

DevL commented 7 years ago

Version used: 0.33

Steps to reproduce

  1. Enter a non-ASCII key as the shortcut key, e.g. å.

Behaviour

  1. The app crashes and keeps crashing on start.
dillonkearns commented 7 years ago

Hello @DevL,

So sorry to hear the app is crashing on you! I will work on a fix. For now, you can prevent the app from crashing by running rm -f * from the local storage folder. If you're on a Mac, these commands will clear your settings so the app is no longer crashing:

cd ~/Library/Application Support/mobster/Local Storage
rm -f *

(Otherwise, this directory is %APPDATA% on Windows $XDG_CONFIG_HOME or ~/.config on Linux, see https://electron.atom.io/docs/api/app/#appgetpathname).

dillonkearns commented 7 years ago

Also @DevL, I'm not sure if the Electron API supports non-ascii shortcuts. Just curious, is it important to your team that you have the shortcut be non-ascii, or would you guys be content with it preventing the crash if you tried?

Thanks for filing the report!

dillonkearns commented 7 years ago

@DevL it looks like the Electron API does not support non-ascii characters (here are the valid options: https://electron.atom.io/docs/api/accelerator/). 540c78e6b3f8aa646e6892f473a167696f4d75f1 prevents the crash by ignoring invalid inputs. Thanks again for the report!

DevL commented 7 years ago

Thanks for looking into it. It's more of a nuisance and surprising behaviour than anything else. Making sure that the app doesn't crash would be appreciated. :-)

dillonkearns commented 7 years ago

@DevL non-ascii characters will no longer crash the be accepted (preventing crashes) as of release 0.0.34 https://github.com/dillonkearns/mobster/releases/tag/v0.0.34. Cheers!