dillonkearns / mobster

Pair and mob programming timer for Mac, Windows, and Linux.
http://mobster.cc
MIT License
308 stars 39 forks source link

Upgrade all dependencies #68

Closed JulioJu closed 4 years ago

JulioJu commented 4 years ago

Upgrade all dependencies to try to fix https://github.com/dillonkearns/mobster/issues/67

Note that the pull request https://github.com/dillonkearns/mobster/pull/66 is already pushed

JulioJu commented 4 years ago

Hi !

I don't know Elm. When we upgrade, there are lot of Elm errors. Could you help me please to finish this PR ?

I don't know if it will fix https://github.com/dillonkearns/mobster/issues/67 , but it's possible. With Electron 5.0.0 and later, when we open dev tools in Electron we see errors about Webpack. When we upgrade Webpack we need to upgrade TypeScript. And upgrade TypeScript seems to cause problems with the module ./src/Timer/Timer.elm And when we upgrade to Elm 0.19, we have errors with Elm, don't know why.

Note that a file named elm.json is created with the upgrade to Elm 0.19. Is it correctly created?

Thanks in advance !

dillonkearns commented 4 years ago

Upgrading Elm is blocked on one of the dependencies not being updated. It's a huge change, I had it going in a branch but got stuck on that issue.

But there's no need to change the Elm version in order to upgrade the Electron binary, so that should be a separate change. If you can get the app working with the latest Electron and work through the issues there then I will merge that in!

JulioJu commented 4 years ago

@dillonkearns ok so cool, thanks !

I was frustrated to not upgrade to the last version of Electron, therefore I have done some tests.

I suppose it's caused of Elm, but you say it's not the problem ?

With https://github.com/dillonkearns/mobster/pull/68/commits/d444cbc4995986d323fbb98857692013dc148182 and the following packjage.json (all upgraded except Elm, that is on version 0.18). (note that " elm-webpack-loader": "^4.4.0 cause problems, therfore I use version 6).

  "devDependencies": {
    "@types/jquery": "^3.3.31",
    "@types/node": "^12.11.1",
    "@types/universal-analytics": "^0.4.2",
    "@types/webpack": "^4.39.3",
    "concurrently": "^5.0.0",
    "devtron": "^1.4.0",
    "electron": "6.0.12",
    "electron-builder": "21.2.0",
    "elm": "^0.18.0",
    "elm-electron": "0.0.3",
    "elm-hot-loader": "^0.5.4",
    "elm-test": "^0.18.12",
    "elm-webpack-loader": "^6.0.0",
    "ts-loader": "^6.2.0",
    "ts-node": "^8.4.1",
    "typescript": "3.6.4",
    "webpack": "^4.41.2",
    "webpack-cli": "^3.3.9",
    "webpack-dev-server": "^3.8.2"
  },
  "dependencies": {
    "bugsnag": "^2.1.3",
    "clipboard": "^2.0.4",
    "electron-debug": "^3.0.1",
    "electron-is-dev": "^1.1.0",
    "electron-log": "^3.0.8",
    "electron-updater": "^4.1.2",
    "highlight.js": "^9.10.0",
    "jquery": "^3.3.1",
    "machine-uuid": "^1.2.0",
    "ms": "^2.1.1",
    "node-osascript": "^2.0.0",
    "universal-analytics": "^0.4.16"
  }

I have the TypeScript error

[1] typescript/timer.ts(1,7): error TS2403: Subsequent variable declarations must have the same type.  Variable 'Elm' must be of type 'typeof import("/tmp/mobster/src/Setup/Main/index")', but

I don't understand why, and I'm frustrated. I thought is caused by Elm 0.18.

Ok, I close this PR, and let you https://github.com/dillonkearns/mobster/issues/67 to be merged, if you want.