search

dillontkh / pe

0 stars 0 forks source link

Duplicate `PatientListPanel` in UML diagram #16

Open dillontkh opened 2 months ago

dillontkh commented 2 months ago

image.png

There are 2 PatientListPanels in the UML diagram above, which could be confusing to the reader.

nus-pe-script commented 2 months ago

Team's Response

Hello thanks for pointing this out! If you see carefully, the one outside of the box is named PatentListPanel instead of PatientListPanel. This is caused by a typo error thus, making the inheritance arrow wrong, and a 'duplicate' patient list panel created. I will count it under a duplicate issue as the typo in Ui component with ID #1710!

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Typo in UI component model

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

image.png

Should be PatientListPanel. However the typo caused the inheritance arrow to be wrong as well.

[original: nus-cs2103-AY2324S2/pe-interim#1404] [original labels: type.DocumentationBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hello, thanks for pointing this out! Indeed there was a type in the PatentListPanel and it should have been PatientListPanel insteald, causing the PUML to create a separate box for PatentListPanel while PatientListPanel is not pointed to UiPart which it should have!

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]