dillontkh / pe

0 stars 0 forks source link

Logs still refer to an "AddressBook" program #3

Open dillontkh opened 6 months ago

dillontkh commented 6 months ago

When starting the UI through the command line, there the logs show Initializing AddressBook although the application is called PatientSync.

This could cause slight confusion for future developers trying to debug the application.

image.png

soc-se-bot commented 6 months ago

Team's Response

Hi, thanks for pointing this out!

However, as mentioned by the Prof. in the Forum, issues related to the terminal (unless they are exceptions, etc.) are not considered testable under the PE.

You can refer to this post for more information: https://github.com/nus-cs2103-AY2324S2/forum/issues/912

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: https://github.com/nus-cs2103-AY2324S2/forum/issues/752

I refer to another post from the forums, where the prof addressed a student asking about this exact same issue (link to PE-D bug report).

There, the prof clearly states in no uncertain terms: "Showing the old app name is qualifies as an error." (In this hyper-specific context.)

Referring to the post you linked, the prof also mentioned "unless it is something that naturally attracts user attention". The phrase Initializing AddressBook is wrapped with ================== which is very clearly intended to attract the reader's attention while reading the console output.