dillontkh / pe

0 stars 0 forks source link

Easy to accidentally insert duplicate patients #4

Open dillontkh opened 2 months ago

dillontkh commented 2 months ago

Having to manually enter a patient's ID that uniquely identifies them allows for accidental entry of duplicate patients due to a simple typo.

e.g. first, add a client with ID 12360

add id/ 12360 n/ John Chan p/ John f/ Curry chicken c/ Stable c/ Has 2 sons visit him regularly h/ Singing karaoke t/Diabetes

The nurse then does something else and forgets that they already added this patient.

They then enter him again, but accidentally make a typo in the ID

add id/ 12369 n/ John Chan p/ John f/ Curry chicken c/ Stable c/ Has 2 sons visit him regularly h/ Singing karaoke t/Diabetes

The result is the same patient being stored twice.

image.png

soc-se-bot commented 2 months ago

Team's Response

Hi, thanks for pointing this out.

However, we have already identified this issue and have also put it down in our Planned Enhancements in our DG (See: Section 4.8)

image.png

Showing the PatientHospitalId would therefore resolve this issue as the nurse can see that this patient already exists.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Having read the planned enhancements in more detail, I still think it does not address the underlying problem of using only the PATIENT_HOSPITAL_ID to identify duplicates.

Considering the real-world scenario of having two patients with the exact same information but different PATIENT_HOSPITAL_IDs, it is unlikely that they are different patients.

In conclusion, I think that using only 1 field to identify duplicates is a feature flaw as a single typo could result in duplicate entries as seen in the original bug report.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]