search

dillontkh / pe

0 stars 0 forks source link

Find command returns too many results #8

Open dillontkh opened 2 months ago

dillontkh commented 2 months ago

If the user has many patients stored, it is not unlikely that there will be patients with similar names or surnames.

If you use the command find alex yeoh jia jun, a possible result could be:

image.png

Given a large enough database of patients, there can be many unrelated results even if you find by the exact full name of the patient.

soc-se-bot commented 2 months ago

Team's Response

Hi! Thanks for your suggestion! I would like to correct that the bug that you raised is indeed the expected behaviour for this feature. It is not related to the find feature delivered in this version. The purpose of the find command in this version is to find all patient whose name matches the any of the keyword(s) and not a specific patient. However, after seeing your concern, we may consider having another command that could cater to the concern you are foreseeing:)

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: After reading the team's UG in more detail, I still stand by my original point that the current implementation of the find command, while it behaves exactly as described in the UG, is a feature flaw.

As a user, if I use find jacob lim jia le, my intention is to specifically look for the patient "jacob lim jia le". It is unlikely that I am looking for patients whose name contains "jacob" or "lim" or "jia" or "le".