search

dillonzq / LoveIt

❤️A clean, elegant but advanced blog theme for Hugo 一个简洁、优雅且高效的 Hugo 主题
https://hugoloveit.com
MIT License
3.35k stars 1.07k forks source link

Resolve favicon href for baseUrl with subpath #792

Closed Perdjesk closed 1 year ago

Perdjesk commented 1 year ago

With: config.toml

baseurl = "https://domain.example/site/"

Before

Produces:

<head>
...
  <link rel="shortcut icon" type="image/x-icon" href="/favicon.ico" />
  <link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png">
  <link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png">
  <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png">
...
</head>

GET 404 on https://domain.example/favicon.ico

After

Produces:

<head>
...
  <link rel="shortcut icon" type="image/x-icon" href="/site/favicon.ico" />
  <link rel="icon" type="image/png" sizes="32x32" href="/site/favicon-32x32.png">
  <link rel="icon" type="image/png" sizes="16x16" href="/site/favicon-16x16.png">
  <link rel="apple-touch-icon" sizes="180x180" href="/site/apple-touch-icon.png">
...
</head>

Might resolve: https://github.com/dillonzq/LoveIt/issues/755 https://github.com/dillonzq/LoveIt/issues/447

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication