dillonzq / LoveIt

❤️A clean, elegant but advanced blog theme for Hugo 一个简洁、优雅且高效的 Hugo 主题
https://hugoloveit.com
MIT License
3.34k stars 1.07k forks source link

We Need to fork :-) #819

Open thomas-louvigne opened 1 year ago

thomas-louvigne commented 1 year ago

Hi, the creator of this amazing theme looks absent. There are 29 PR in pending. I try to send him message on twitter but it don't answer me.

I am too noob to manage this fork, but i will do my best to help...

Who want start it ?

thomas-louvigne commented 1 year ago

So i did it : https://github.com/thomas-louvigne/LoveItAgain/

jamesdeluk commented 1 year ago

I did find https://github.com/HEIGE-PCloud/DoIt which is kind of a fork and kept updated. Haven't looked too deeply yet though.

thomas-louvigne commented 1 year ago

Ho, it is realy intering ! Thank you. It looks great ! Perhaps we could all go to this fork ?

CXwudi commented 1 year ago

I am using HEIGE-PCloud/DoIt for my own blog, and I'd to say it has been working great. The author usually responses to issues within like a few days.

hakula139 commented 1 year ago

I just keep my own fork and simply fix any bugs that I've found while using. 😄

thomas-louvigne commented 1 year ago

@CXwudi : I have send MR, espacialy about the translation. If it is accepted, i think i will go on this version. @hakula139 , can we see what you have updated in your version ? Do you have any reason to not switch to DoIt version ?

hakula139 commented 1 year ago

@hakula139 , can we see what you have updated in your version ? Do you have any reason to not switch to DoIt version ?

Well, I mainly maintain it for personal use, so there'll be many minor changes that may sound good to me, but may not be necessarily accepted as a PR (e.g. changing paddings or whitespaces). So even if I switch to a DoIt fork, I'll still need to keep a personal fork for this kind of changes. That's why I may not switch to another fork, considering that LoveIt is generally complete with little need to update, just some bug fix seems to be ok.

I left that comment because I've already seen many people attempting to maintain a community fork of this theme and trying to migrate users from here to there, which end up becoming yet another personal fork as mine (not updating regularly or containing some personal customizations). And for most cases we don't actually need a community fork, especially for something like a personal blog theme, as we may just need to change little things like localization, personal-taste style customization, features that are not actually needed by most users. Then from a pragmatic perspective, keeping a personal fork is just fine for these cases, and I'm here to simply suggest this option.

CXwudi commented 1 year ago

@hakula139 , can we see what you have updated in your version ? Do you have any reason to not switch to DoIt version ?

Well, I mainly maintain it for personal use, so there'll be many minor changes that may sound good to me, but may not be necessarily accepted as a PR (e.g. changing paddings or whitespaces). So even if I switch to a DoIt fork, I'll still need to keep a personal fork for this kind of changes. That's why I may not switch to another fork, considering that LoveIt is generally complete with little need to update, just some bug fix seems to be ok.

I left that comment because I've already seen many people attempting to maintain a community fork of this theme and trying to migrate users from here to there, which end up becoming yet another personal fork as mine (not updating regularly or containing some personal customizations). And for most cases we don't actually need a community fork, especially for something like a personal blog theme, as we may just need to change little things like localization, personal-taste style customization, features that are not actually needed by most users. Then from a pragmatic perspective, keeping a personal fork is just fine for these cases, and I'm here to simply suggest this option.

Tbh, if your reason of forking is meanly just personal customization, then you don't really need a fork, as you can override almost any part of the theme within your blog source code, take a look of this awesome Chinese post about his customization to LoveIt without maintaining a fork

hakula139 commented 1 year ago

@CXwudi Keeping a personal fork is for maintaining a detailed commit history and merging updates from upstream whenever needed and possible. There's no need to teach me how and when to use a fork, and the practice you suggested in the post is exactly what I strongly discourage, yet I believe arguing over it is quite off the topic, so I'll just stop here.

Btw, you might just check my blog to see whether I'm familiar with these sort of things. I do know what I'm doing.

CXwudi commented 1 year ago

@hakula139 I am not trying to argue with you nor do I want to. I just want to point out that method in case if u don't know and also for reference if more ppl come to this thread. Whatever way you prefer is totally your business and I don't care

thomas-louvigne commented 1 year ago

So i switch to the DoIt fork.

wu0407 commented 10 months ago

like https://github.com/hugo-fixit/FixIt