dilyabareeva / quanda

A toolkit for quantitative evaluation of data attribution methods.
https://quanda.readthedocs.io
MIT License
33 stars 0 forks source link

When to filter by prediction and class? #174

Closed gumityolcu closed 1 month ago

gumityolcu commented 1 month ago

Argument to filter in metrics: It makes conceptual sense to do the filtering inside the metric, is also better for a user that has precomputed explanations.

Argument to filter in benchmarks, before updating metric: Explanation is expensive. It's just a waste of time to compute unneeded explanations in the benchmark

dilyabareeva commented 1 month ago

Why not both?

We can leave the filtering functionality in the metric

And do pre-filtering in the benchmark if the argument is filter_by_prediction/class = True, to not calculate unnecessary explanations

In downloadable benchmarks I did the pre-filtering step