dilyabareeva / quanda

A toolkit for quantitative evaluation of data attribution methods.
https://quanda.readthedocs.io
MIT License
33 stars 0 forks source link

Coverage #86

Closed gumityolcu closed 4 months ago

gumityolcu commented 4 months ago

Hello,

Coverage is at 90 %

With the following caveats:

1- We omit files that are not used anywhere currently:

2- We don't yet test:

gumityolcu commented 4 months ago

Hello Dilya, thanks for the feedback!

incorporated most of it.

The only thing is, I don't get what you mean by "tmp_path" because currently in main it is an extra parameter that does not get a value. So i was confused and I removed it. You can either tell me or do your own edit about it (if it's a quick fix as i imagine)

Any other feedback is of course also welcome!

gumityolcu commented 4 months ago

Hi

I tried to name everything using class and method names.

I added in the tmp_path fixture 😅