dima-bu / react-time-input

A simple react component for select time in format HH:mm
https://github.com/dima-bu/react-time-input.git#readme
MIT License
54 stars 33 forks source link

input type is being set to [native function] #13

Closed nodeEnthu closed 7 years ago

nodeEnthu commented 7 years ago

I think you forgot to call this function on type={this.getType} in line 124 timeInput.jsx. So the input type is being like

input type="function () { [native code] }" class="width-max" placeholder=" " value="10:30"

  render () {
        return (
            <input
                name={(this.props.name)? this.props.name : undefined}
                className={this.props.className}
                type={this.getType}
                disabled={this.props.disabled}
                placeholder=" "
hasnat commented 7 years ago

Nice one, thanks for notifying about this, https://github.com/dima-bu/react-time-input/commit/7f020eaacde857c57e289701195f32140b019183 should fix it

@dima-bu can you make sure this gets to npm

hasnat commented 7 years ago

I will keep this open till @dima-bu releases this to npm