search

dima-dencep / rrls

Makes resource packs load in the background, allowing you to do other things while waiting!
https://curseforge.com/minecraft/mc-mods/rrls
Open Software License 3.0
38 stars 14 forks source link

Crash with Hey Wiki and Zoomify #108

Closed Dianliang233 closed 3 weeks ago

Dianliang233 commented 3 weeks ago

Minecraft version.

1.21

Remove Reloading Screen version.

5.0.0+mc1.21-fabric

What happened?

  1. Install Hey Wiki, Zoomify, RRLS & dependency
  2. Run game
  3. Game crashes

Relevant logs

Log: pastebin.com/sExLhZVi password: heywiki Crash log: files.catbox.moe/bnozsp.txt no password

Additional information

This was originally reported as https://github.com/mc-wiki/minecraft-mod-heywiki/issues/58. I have since narrowed it down to three mods: RRLS, Hey Wiki and Zoomify.

Hey Wiki requires some resources to be loaded and it will manipulate the TitleScreen

dima-dencep commented 3 weeks ago

Update rrls

Dianliang233 commented 3 weeks ago

@dima-dencep I can also reproduce this in the latest version (5.0.7)

dima-dencep commented 3 weeks ago

I can't fix it in rrls, since heywiki does mixin, the fix has to be done there (which I see has been done)

I just woke up, I have no idea how to fix this in rrls, maybe your ideas?

dima-dencep commented 3 weeks ago

To some extent, this is a duplicate of #87

Dianliang233 commented 3 weeks ago

I'm a bit curious – is it intended for TitleScreen to be shown even if not all resources are loaded?

Dianliang233 commented 3 weeks ago

The fix seems to be simple enough — just need to get the part where the resource reloader is depended into the closure so that it is only executed when needed. I'm still curious why it requires RRLS and Zoomify to be installed in order for this issue to appear. Especially the Zoomify part, because I can't figure out how the heck Zoomify would play a role here.

dima-dencep commented 3 weeks ago

is it intended for TitleScreen to be shown even if not all resources are loaded?

yeah, it's for all screens