dima-dencep / rubidium-extra

Features that shouldn't be in Rubidium.
GNU Lesser General Public License v3.0
8 stars 9 forks source link

[1.19.2] ThreatenGL incompatibility. #86

Open JelowPapua opened 3 months ago

JelowPapua commented 3 months ago

Make sure you are not opening a duplicate.

Minecraft version.

1.19.2

Rubidium/Embeddium Extra version.

0.4.19

Rubidium/Embeddium version.

0.3.18.1

What happened?

Embeddium Extra and ThreatenGL try to modify the same mixin: [Render thread/WARN] [mixin/]: @Redirect conflict. Skipping sodium-extra.mixins.json:reduce_resolution_on_mac.MixinWindow->@Redirect::onDefaultWindowHints(II)V with priority 1000, already redirected by threatengl.mixins.json:ThreatenGLMixin->@Redirect::hintOverride(II)V with priority 1000

I tried replicating the issue on Fabric 1.19.2 and installing Sodium, Sodium Extra and ThreatenGL and it ran perfectly, no Sodium Extra incompatibility, then I tried doing a clean installation of Forge 1.19.2 with Embeddium, Embeddium (Rubidium) Extra and ThreatenGL and the crash persisted so the problem seems to be the Forge port of Embeddium Extra, I tried looking into that mixin of the Forge port and from line 31 to 38 it's a bit different:

Fabric https://github.com/FlashyReese/sodium-extra-fabric/blob/1.19.x/dev/src/main/java/me/flashyreese/mods/sodiumextra/mixin/reduce_resolution_on_mac/MixinWindow.java#L31-L38

Forge https://github.com/dima-dencep/rubidium-extra/blob/1.19.x/stable/src/main/java/me/flashyreese/mods/sodiumextra/mixin/reduce_resolution_on_mac/MixinWindow.java#L31-L38

I don't know if this is even useful but it might just help.

Relevant logs

https://pastebin.com/eGBpEnsb

Additional information

No response

JelowPapua commented 1 month ago

I got the mods working together by downloading the files for 1.19.x and building a version without the "reduce resolution on mac" mixin and any mention of it within the mod's files, this don't break anything on my end since I use windows. Anyway, the problem seems to lie in that mixin if it's of any help.

Weirdly enough, they don't conflict each other on their Fabric counterparts as I mentioned before in the issue.