search

dima117 / Chart.Scatter

Scatter chart plugin for Chart.js
http://dima117.github.io/Chart.Scatter
MIT License
97 stars 26 forks source link

Compatibility layer for Chart.js #11

Closed sroze closed 9 years ago

sroze commented 9 years ago

It appears that Chart.js sends graph initialisation parameter with an object that contains datasets instead of sending datasets directly.

This adds the compatibility layer that supports this.

dima117 commented 9 years ago

I'm sorry for late reply. I'll review your PR during one day.

dima117 commented 9 years ago

Can you give an example when this compatibility would be useful?

dima117 commented 9 years ago

The scatter chart generates his labels based on value of points. So it uses only one field - array of datasets. I think an additional wrapper around datasets isn't good idea.

I'll merge your changes if you give the example, which show that it would be useful.

sroze commented 9 years ago

@dima117 basically, it's required to work with the angular-chart.js integration because it's the kind of objects it's working with with it creates the data.

dima117 commented 9 years ago

Done. I'll update minified files soon.

sroze commented 9 years ago

Thanks :+1:

dima117 commented 9 years ago

Minified files has been updated.

sroze commented 9 years ago

Awesome! :+1;

On Wednesday, June 24, 2015, dima117 notifications@github.com wrote:

Minified files has been updated.

— Reply to this email directly or view it on GitHub https://github.com/dima117/Chart.Scatter/pull/11#issuecomment-114985347.