search

dima74 / intellij-indent-rainbow

Extension which shows indentation with a faint rainbow colored background to make them more readable
https://plugins.jetbrains.com/plugin/13308-indent-rainbow/
GNU General Public License v3.0
64 stars 13 forks source link

Disagreement between Indent Rainbow and PhpStorm with Twig #30

Closed YetAnotherDevWannabe closed 2 years ago

YetAnotherDevWannabe commented 3 years ago

When using Twig, indent rainbow and phpStorm seem to not agree on the correct indentation :

IndentRainbowTwig This is after re-formating my code. Apparently, for phpStorm inside a twig block you need to indent, but not for IR.

This is what IR wants :

IndentRainbowTwig2

dima74 commented 2 years ago

Thanks for report and sorry for long response.

Apparently, for phpStorm inside a twig block you need to indent

Which formatter do you use (built-in or some external one)? I can't reproduce it with default PhpStorm settings:

YetAnotherDevWannabe commented 2 years ago

Hi,

I believe I used a custom one at the time. Since then I had to switch to vscode sadly so I don't know if I still have the problem.

Le jeu. 11 nov. 2021 à 13:19, Dmitry Murzin @.***> a écrit :

Thanks for report and sorry for long response.

Apparently, for phpStorm inside a twig block you need to indent

Which formatter do you use (built-in or some external one)? I can't reproduce it with default PhpStorm settings:

https://user-images.githubusercontent.com/6505554/141296727-929f9c11-0591-4335-94cf-3cd8514e1765.gif

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dima74/intellij-indent-rainbow/issues/30#issuecomment-966257537, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOGDTOTF34H5IS6PU4ICV3ULOYFLANCNFSM47ADZY5A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

BorisKM commented 2 years ago

Thanks for report and sorry for long response.

Apparently, for phpStorm inside a twig block you need to indent

Which formatter do you use (built-in or some external one)? I can't reproduce it with default PhpStorm settings:

The same problem but with blade directives...

dima74 commented 2 years ago

Should be fixed in v2.0.2 where we started to use indent-based highlighter by default