search

dima767 / inspektr

Lightweight non-Intruisive Auditing and Logging capabilities for Java
https://github.com/dima767/inspektr/wiki/Inspektr-Auditing
Apache License 2.0
74 stars 60 forks source link

Auditing failures shouldn't cause functional failures #16

Open apetro opened 11 years ago

apetro commented 11 years ago

Currently, Inspektr asserts that its arguments not be null. When these assertions fail, the action being audited fails.

Instead, failure in the audit trail system should not induce failure in the system being audited. Failure should be logged and control return from the Aspect to the functional code wrapped.

Cf. Issue #13 , which helped but didn't go far enough.

Cf. https://groups.google.com/d/topic/cas-user/e2FRrJj0BFU/discussion

battags commented 11 years ago

Having read the discussion where root cause has still not been determined, it would be good to confirm what the actual issue is before creating this issue. The issue could lie elsewhere.

battags commented 11 years ago

Also, at worst failure should be optional. There are numerous environments where one should not be allowed to proceed if something cannot be audited.

serac commented 11 years ago

https://github.com/dima767/inspektr/issues/10 is in the same vein, although perhaps more specific, as this issue. Some extra error handling is harmless at worst and incredibly valuable at best. I would think you would at least want to consider it.

sunnymoon commented 8 years ago

We had this problem in production system... With JASIG CAS server. One error during an @Audit method caused the AuditTrailManagementAspect to catch that original exception, which it should rethrow (and normally would), but as one of the resolvers couldn't actually obtain the correct information, the "executeAuditCode" method blew up with an exception and the original exception was totally forgotten.

I guess that in the methods "handleAuditTrail", we could change it to something more solid in terms of exception reporting.

sunnymoon commented 8 years ago

I just created a pull request with a proposed solution.