dimaMachina / graphql-eslint

ESLint parser, plugin and set rules for GraphQL (for schema and operations). Easily customizable with custom rules. Integrates with IDEs and modern GraphQL tools.
https://the-guild.dev/graphql/eslint
MIT License
778 stars 102 forks source link

fix lint error with custom CSS class #2300

Open comatory opened 1 month ago

comatory commented 1 month ago

Relates to #2261 - this makes the linter pass all the checks. The issue is that "nextra" is some kind of indirect dependency for the website but two components are using nextra-scrollbar CSS class.

I fixed this by adding this class to whitelist of the tailwindcss/no-custom-classname eslint rule.

Description

I wanted to contribute to the project but was bothered that basic checks do not work. I decided to do this quick fix.

Fixes #2299

Type of change

Please delete options that are not relevant.

Screenshots/Sandbox (if appropriate/relevant):

N/A

How Has This Been Tested?

Run pnpm lint on your local machine, all checks should pass. These checks should now also pass in CI

Test Environment:

Checklist:

Further comments

Maybe the lint rule is correct and we shouldn't use the custom class name. But depending on nextra seems indirect, searching for it only yields results in pnpm-lock.yaml. So to me, it even seems very suspicious, perhaps we could delete it?

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 503f4cdc234b53e81ca5ab82b6f2a7f3b429ce3a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR