Enforce `require-selections` on `FragmentSpread`s within `GraphQLUnionType`s

maciesielka commented 1 month ago

Description

Enforces require-selections on FragmentSpreads within GraphQLUnionTypes, like it already does for InlineFragments

Fixes #2318

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

(Technically this can cause new violations in existing codebases, but I'd consider this to be missing functionality and thus a bug more than a new feature).

How Has This Been Tested?

Added a unit test that describes and reproduces the issue well.

Checklist:

[x] I have followed the CONTRIBUTING doc and the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests and linter rules pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 11ebcef86d5bf06cb3c495725973b4e510c82ba7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ----------------------------- | ----- | | @graphql-eslint/eslint-plugin | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

maciesielka commented 2 weeks ago

@dimaMachina any guidance for how to get this reviewed?

dimaMachina / graphql-eslint