dimaMachina / graphql-eslint

ESLint parser, plugin and set rules for GraphQL (for schema and operations). Easily customizable with custom rules. Integrates with IDEs and modern GraphQL tools.
https://the-guild.dev/graphql/eslint
MIT License
779 stars 101 forks source link

exposes GraphQLESTreeNode type #2418

Closed comatory closed 6 days ago

comatory commented 6 days ago

Description

We use some custom eslint plugins that build on top of @graphql-eslint/eslint-plugin and it cannot be imported directly from the package if Typescript's config is set to use moduleResolution: NodeNext or any other resolution type. This means explicitly making it public is the easiest way to use it.

Fixes #2399

Type of change

Please delete options that are not relevant.

Screenshots/Sandbox (if appropriate/relevant):

N/A

How Has This Been Tested?

No, it is just exposing new type.

Test Environment:

N/A

Checklist:

Further comments

Unfortunately, I'm not able to make tests pass locally. I get this failure:

@graphql-eslint/eslint-plugin:test:  FAIL  __tests__/examples.spec.ts > Examples > should work in monorepo
@graphql-eslint/eslint-plugin:test: Error:
@graphql-eslint/eslint-plugin:test: Oops! Something went wrong! :(
@graphql-eslint/eslint-plugin:test:
@graphql-eslint/eslint-plugin:test: ESLint: 8.57.0
@graphql-eslint/eslint-plugin:test:
@graphql-eslint/eslint-plugin:test: file:///Users/ondrej.synacek/Projects/graphql-eslint/packages/plugin/dist/esm/types.js:2
@graphql-eslint/eslint-plugin:test: import { GraphQLESTreeNode as GraphQLESTreeNode2 } from "./estree-converter/types.js";
@graphql-eslint/eslint-plugin:test:          ^^^^^^^^^^^^^^^^^
@graphql-eslint/eslint-plugin:test: SyntaxError: The requested module './estree-converter/types.js' does not provide an export named 'GraphQLESTreeNode'
es.js' does not provide an export named 'GraphQLESTreeNode'

Can I ask for assistance on this one? 🙇 Thanks

changeset-bot[bot] commented 6 days ago

🦋 Changeset detected

Latest commit: edb511580389337022c755544b7181256ad16c0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------------------- | ----- | | @graphql-eslint/eslint-plugin | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR