Accept without personal number

dimafe6 / bank-id

BankID

MIT License

30 stars 26 forks source link

Closed jongotlin closed 5 years ago

jongotlin commented 5 years ago

Passing personal number is optional.

[x] Code compiles correctly
[x] Code conforms PSR-2. Recommending use PHP CS Fixer with next rules: --rules=@PSR2,blank_line_before_return,no_unused_imports
[ ] Created tests which fail without the change (if possible)
[ ] All tests passing
[x] Extended the README, if necessary
[ ] Added myself / the copyright holder to the authors in composer.json file

jongotlin commented 5 years ago

I don't think passing real requests in tests will work.

lurifuchs commented 5 years ago

What's the status for this PR? I would like to see this merge, solution looks good.

jongotlin commented 5 years ago

Thanks for merging. Can you please tag a release on Packagist? dev-dev is not pointing to the latest commit.