search

dimafe6 / bank-id

BankID
MIT License
30 stars 26 forks source link

"personalNumber" should be optional while authenticating #6

Closed oakleaf closed 4 years ago

oakleaf commented 5 years ago

58 in BankIDService.php; "personalNumber" is optional while authenticating. This relies on paragraph "14.1.1 Parameters for auth and sign" from https://www.bankid.com/assets/bankid/rp/bankid-relying-party-guidelines-v3.2.2.pdf.

Suggestion; Just check if the $personalNumber not is null, if not, include it in the parameters.

Livijn commented 5 years ago

Why did you close this? It makes sense.

Livijn commented 4 years ago

Should be closed since this was actually added in #5