search

dimagi / commcare-android

Offline First Android software client for CommCare, the world's largest platform for designing, managing, and deploying robust mobile applications to frontline workers worldwide
https://www.dimagi.com/open-source/
Apache License 2.0
37 stars 25 forks source link

Remove test credentials from release build #2797

Closed avazirna closed 4 weeks ago

avazirna commented 1 month ago

Summary

Our release BuildConfig class contains test credentials that are used by instrumentation tests. This PR makes these credentials only available to the Instrumentation tests BuildConfig class.

After this change, here are the fields available in the release BuildConfig class

# static fields
.field public static final ANALYTICS_TRACKING_ID_DEV:Ljava/lang/String; = ""
.field public static final ANALYTICS_TRACKING_ID_LIVE:Ljava/lang/String; = ""
.field public static final APPLICATION_ID:Ljava/lang/String; = "org.commcare.dalvik"
.field public static final BUILD_DATE:Ljava/lang/String; = "2024-08-13"
.field public static final BUILD_NUMBER:Ljava/lang/String; = "..."
.field public static final BUILD_TYPE:Ljava/lang/String; = "release"
.field public static final CCC_HOST:Ljava/lang/String; = "connect.dimagi.com"
.field public static final CC_AUTHORITY:Ljava/lang/String; = "org.commcare.dalvik"
.field public static final CONSUMER_APP_PASSWORD:Ljava/lang/String; = ""
.field public static final CONSUMER_APP_USERNAME:Ljava/lang/String; = ""
.field public static final DEBUG:Z = false
.field public static final FIREBASE_DATABASE_URL:Ljava/lang/String; = "..."
.field public static final FLAVOR:Ljava/lang/String; = "commcare"
.field public static final IS_CONSUMER_APP:Z = false
.field public static final IS_SINGLE_APP_BUILD:Z = false
.field public static final MAPBOX_SDK_API_KEY:Ljava/lang/String; = "..."
.field public static final ODK_AUTHORITY:Ljava/lang/String; = "org.commcare.android.provider.odk"
.field public static final TRUSTED_SOURCE_PUBLIC_KEY:Ljava/lang/String; = "xxx"
.field public static final USE_CRASHLYTICS:Z = true
.field public static final VERSION_CODE:I = 0x72102
.field public static final VERSION_NAME:Ljava/lang/String; = "2.54"

Safety Assurance

Safety story

This is only relevant to the build process.

avazirna commented 1 month ago

@damagatchi retest this please

avazirna commented 1 month ago

@damagatchi retest this please