Fixes Crash on App Resume after Session Expiration + Logs - Githubissues

dimagi / commcare-android

Offline First Android software client for CommCare, the world's largest platform for designing, managing, and deploying robust mobile applications to frontline workers worldwide

https://www.dimagi.com/open-source/

Apache License 2.0

37 stars 25 forks source link

Fixes Crash on App Resume after Session Expiration + Logs #2814

Closed shubham1g5 closed 4 weeks ago

shubham1g5 commented 1 month ago

Summary

Handles SessionExpiration in the home button view setup, this escapes the default session expiration and causes the app to crash when resuming after a session expiration event. Other buttons already have this safety implemented and sync was the only one remaining.
Adds some helpful logs around session expiration

Safety Assurance

[x] If the PR is high risk, "High Risk" label is set
[x] I have confidence that this PR will not introduce a regression for the reasons below
[x] Do we need to enhance manual QA test coverage ? If yes, "QA Note" label is set correctly

shubham1g5 commented 4 weeks ago

I don't see a need to QA this as it just adds a try-catch block. Are there specific concerns you are thinking of ?

avazirna commented 4 weeks ago

I don't see a need to QA this as it just adds a try-catch block. Are there specific concerns you are thinking of ?

No concern in particular, I'm happy to follow your lead on this.