search

dimagi / django-prbac

Other
139 stars 38 forks source link

Hi there! #28

Closed bnisevic closed 7 years ago

bnisevic commented 8 years ago

Is this thing alive? Will you make it compatible with Django 1.10?

NoahCarnahan commented 8 years ago

Hi, this project is indeed alive, and still in use by us internally. We're currently in the process of upgrading our site to 1.9, and I believe another member of our team recently made a PR in django-prbac for 1.9 compatibility. @nickpell do you know if that was all the work necessary for 1.9 compatibility of this repo?

I don't think any of us have looked at what changes might be necessary for 1.10 use, but this is pretty light weight project, so it's possible that its already compatible! In which case we just need to update setup.py. If you're interested, feel free to run the tests on 1.10 and see what happens. Or, if you already know what there are breaking changes, feel free to submit a PR or let us know what they are. Thanks!

nickpell commented 8 years ago

@bnisevic I don't know of any existing incompatibilities with django 1.9/1.10. I plan on ensuring its compatibility in the upcoming weeks to months.

bnisevic commented 8 years ago

I had errors with json-file and South. Let me try it with master branch instead of release. Maybe that will help.

bnisevic commented 8 years ago

Actually that doesn't work because you have clear dependency there: django<1.9,>=1.7a

nickpell commented 7 years ago

With https://github.com/dimagi/django-prbac/pull/30 we now support django 1.8 through 1.10.