search

dimagi / django-prbac

Other
139 stars 38 forks source link

Remove bad code from flake8 config. #68

Closed czue closed 1 year ago

czue commented 1 year ago

I think historically this failed silently but fails hard on newer versions of flake8, resulting in failures.

coveralls commented 1 year ago

Coverage Status

Coverage increased (+0.02%) to 90.59% when pulling c9dbcd325ab9ab02ffea06c4cd8386027bc29563 on flake8 into de01a2e37a45a7082bcc13298b20efa7c6bd89f3 on master.

coveralls commented 1 year ago

Coverage Status

Coverage remained the same at 90.569% when pulling c9dbcd325ab9ab02ffea06c4cd8386027bc29563 on flake8 into de01a2e37a45a7082bcc13298b20efa7c6bd89f3 on master.

czue commented 1 year ago

Ah, good to know! Build fail is not related. Am I allowed to merge this?

millerdev commented 1 year ago

Looks like tests failed on Python 3.7, which is not EOL yet so we should probably continue to support. Would be good to have them passing before merging.

millerdev commented 1 year ago

https://github.com/dimagi/django-prbac/pull/69

czue commented 1 year ago

thanks