dimagi / open-chat-studio

A web based platform for building Chatbots backed by Large Language Models
BSD 3-Clause "New" or "Revised" License
16 stars 7 forks source link

Create new experiment version async #902

Closed SmittieC closed 1 hour ago

SmittieC commented 4 days ago

Resolves #901

Description

Since creating versions of router experiments with assistant children and many files bombed out (gateway timeout), we're now creating versions async.

User Impact

users should be able to create versions of large assistants. Should being the keyword here

Demo

Will include one once the UI is done

Docs

codecov-commenter commented 4 days ago

Codecov Report

Attention: Patch coverage is 80.00000% with 10 lines in your changes missing coverage. Please review.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/experiments/views/experiment.py 28.57% 10 Missing :warning:
Additional details and impacted files

:loudspeaker: Thoughts on this report? Let us know!

SmittieC commented 4 days ago

Ready

SmittieC commented 4 days ago

I'm not convinced that we should be creating a bunch of tasks in the management command, but it will fail for some assistants if we do not. Maybe we should be smarter in the management command and figure out when to give it to a task? I propose:

  1. We see how this does with the large assistants
  2. If it goes well, we can create versions async for experiments with assistants that have > X files.
stephherbers commented 4 days ago

if this does work, before creating a command it would be good to know how many it would be affecting and if manual retry is the way to go