search

dimagi / required-labels

🏷 Automated label checking for GitHub pull requests
BSD 3-Clause "New" or "Revised" License
47 stars 16 forks source link

Use config for label requirements and auth, add tests #1

Closed amstone326 closed 7 years ago

amstone326 commented 7 years ago

@proteusvacuum Thanks for the feedback, think I've addressed everything now

amstone326 commented 7 years ago

@proteusvacuum pushed the next set of changes. If this is good to go, I'm hoping early next week I can actually create the webhook on Github and test it. To do that I think we have 3 options:

  1. Start hosting this if you think it will be easy. I'm not sure what you had in mind for that, so we should talk about it.
  2. I can quickly set up a jenkins job that would just run this as a script for now, and connect the Webhook to that.
  3. Test it locally using something like ngrok, which GitHub actually recommends in their docs, but I've never used it.

No strong opinions; I might just start with 3 and see how easy it is.

proteusvacuum commented 7 years ago

Sounds good to start with 3 so that you can quickly iterate on it while trying it out.