search

dimahardie / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

Mac OS X minidump generation code doesn't handle x86-64 properly #372

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
1. Dump generator uses sysctlbyname("hw.cputype",...) to get cpu type, which 
returns CPU_TYPE_X86 (7) even if it is a x64 kernel.
2. Processor architecture must be set to MD_CPU_ARCHITECTURE_AMD64 for x86_64 
dumps. If it is not then MinidumpContext::CheckAgainstSystemInfo() will fail 
when processing a x86_64 dump.

Original issue reported on code.google.com by amordo...@gmail.com on 23 Feb 2010 at 12:39

GoogleCodeExporter commented 9 years ago 
Hrm, I guess we allow the opposite, an x86 dump on an x86_64 system:
http://code.google.com/p/google-breakpad/source/browse/trunk/src/processor/minid
ump.cc#806

Does the Minidump writing code compile and work on 64-bit OS X? I thought we had
other bugs anyway.

Original comment by ted.mielczarek on 29 Mar 2010 at 5:03

GoogleCodeExporter commented 9 years ago 
I'm looking into this.

Original comment by ted.mielczarek on 27 Apr 2010 at 5:24

GoogleCodeExporter commented 9 years ago

Original comment by ted.mielczarek on 27 Apr 2010 at 5:33

GoogleCodeExporter commented 9 years ago 
I have a patch up for review that makes dump generation work on 64-bit OS X:
http://breakpad.appspot.com/103001

Original comment by ted.mielczarek on 28 Apr 2010 at 7:47

GoogleCodeExporter commented 9 years ago 
Fixed in r578.

Original comment by ted.mielczarek on 29 Apr 2010 at 6:04