Module descriptions with embedded newlines destroy the machine-readable output of minidump_stackwalk

What steps will reproduce the problem?
The pdb filename in some of our crash reports has embedded newlines. When
minidump-stackwalk prints these lines, it ends up with:

Module|olek8r4u.dll|6.0.6000.16386|\\xc2\\xeb\\x17\\x04J\\xb6:\\xbaT\\xf3\\xef\\
xe8Y\\x90\\x86\\xaa\\xe5\\x16n\\xb1\\x80\\x85\\t\\x12!\\x16\\x0f\\x98\\xf8\\x89\
\x16"\\x96\\xd4\\x84\\x88\\xea\\xe3\\r\\r\\x1b\\xca\\x85*^h\\xf5\\xdc\n\\xd9\\xf
4}j\\x1d7\\xe39o\\x1f\\xc5\\xc4\\xa6x\\x8ba\\xe8\\xd6K\\x89H\\xe1\\xff\\xe7\\xf5
\\xf0Y\\xfd\\xf5\\xdbu\\x0c\\x07\\x86\\xed|29E0B04FCCBE47EB86A6C819E8B89D051|0x0
0f60000|0x00ff2fff|0\n

Which has an embedded newline and the machine parser can't handle it. The
patch I will attach just strips the embedded newline, just as we strip
embedded | separator characters.

Original issue reported on code.google.com by bsmedb...@gmail.com on 14 Apr 2010 at 2:59

Attachments:

strip-newlines.patch

dimahardie / google-breakpad

Module descriptions with embedded newlines destroy the machine-readable output of minidump_stackwalk #383