search

dimahardie / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

don't remove '_' prefix and '@' suffix on dump_sym for Win64 PDB/EXE/DLL #467

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. run dump_sym.exe

What is the expected output? What do you see instead?
don't remove 

Win32/x86 symbols have prefix and suffix for calling conversion.  But Win64/x64 
doesn't have.  So If pdb/exe/dll is Win64 image, we should not remove it.

What version of the product are you using? On what operating system?
Windows 7 x64

Please provide any additional information below.
If image is IMAGE_FILE_MACHINE_AMD64, dump_sym doesn't modify name by 
PDBSourceLineWriter::GetSymbolFunctionName

Original issue reported on code.google.com by makoto...@gmail.com on 15 Feb 2012 at 3:04

GoogleCodeExporter commented 9 years ago 
Win64 symbol processing works fine for me as of r1319 - can you try again?

Original comment by wfh@chromium.org on 23 Apr 2014 at 5:30