dimahardie / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

src\client\linux\crash_generation\crash_generation_client.cc dont builds for android using windows version of ndk #479

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Build of crash_generation_client.cc with command line like

C:/lib/necessitas/android-ndk-r7b/toolchains/arm-linux-androideabi-4.4.3/prebuil
t/windows/bin/arm-linux-androideabi-g++ -c -Wno-psabi -march=armv5te 
-mtune=xscale -msoft-float -fpic -ffunction-sections -funwind-tables 
-fstack-protector -fno-short-enums -DANDROID -D__ARM_ARCH_5__ -D__ARM_ARCH_5T__ 
-D__ARM_ARCH_5E__ -D__ARM_ARCH_5TE__ -Wa,--noexecstack -DQT_NO_QWS_TRANSFORMED 
-fdata-sections -ffunction-sections -fexpensive-optimizations 
-fvisibility=hidden -fvisibility-inlines-hidden -mthumb -Os -g 
-fomit-frame-pointer -fexceptions -fno-strict-aliasing -finline-limit=64 -fPIC 
-Wall -Wno-psabi -W -D_REENTRANT  <STRIPPED> -o 
tmp/release/obj/crash_generation_client.o 
../../../third_party/google-breakpad/src/client/linux/crash_generation/crash_gen
eration_client.cc

fails with the following message

C:\Windows\ccMy9g7Y.s: Assembler messages:
C:\Windows\ccMy9g7Y.s:116: Error: invalid immediate: 288 is out of range
C:\Windows\ccMy9g7Y.s:242: Error: invalid immediate: 296 is out of range

Incorrect patch, which fixes build but breaks functionality is attached. As you 
can conclude from the patch the following lines causes this error:

sys_socketpair(AF_UNIX, SOCK_STREAM, 0, fds);
and
sys_sendmsg(server_fd_, &msg, 0)

in method  CrashGenerationClient::RequestDump(const void* blob, size_t 
blob_size)

Is it possible to fix this issue correctly somehow?

C:\...ins\arm-linux-androideabi-4.4.3\prebuilt\windows\bin>"arm-linux-androideab
i-g++.exe" -v
Using built-in specs.
Target: arm-linux-androideabi
Configured with: /tmp/ndk-digit/src/build/../gcc/gcc-4.4.3/configure 
--prefix=/opt/digit/repo/opensource/ndk/toolchains/
arm-linux-androideabi-4.4.3/prebuilt/windows --target=arm-linux-androideabi 
--host=i586-mingw32msvc --build=x86_64-linux
-gnu --with-gnu-as --with-gnu-ld --enable-languages=c,c++ 
--with-gmp=/tmp/ndk-digit/build/toolchain/temp-install --with-
mpfr=/tmp/ndk-digit/build/toolchain/temp-install --disable-libssp 
--enable-threads --disable-nls --disable-libmudflap --
disable-libgomp --disable-libstdc__-v3 --disable-sjlj-exceptions 
--disable-shared --disable-tls --with-float=soft --with
-fpu=vfp --with-arch=armv5te --enable-target-optspace --enable-initfini-array 
--disable-nls --prefix=/opt/digit/repo/ope
nsource/ndk/toolchains/arm-linux-androideabi-4.4.3/prebuilt/windows 
--with-sysroot=/opt/digit/repo/opensource/ndk/toolch
ains/arm-linux-androideabi-4.4.3/prebuilt/windows/sysroot 
--with-binutils-version=2.19 --with-mpfr-version=2.4.1 --with-
gmp-version=4.2.4 --with-gcc-version=4.4.3 --with-gdb-version=6.6 
--with-arch=armv5te --program-transform-name='s,^,arm-
linux-androideabi-,'
Thread model: posix
gcc version 4.4.3 (GCC)

Original issue reported on code.google.com by feiwr...@gmail.com on 5 May 2012 at 9:17

Attachments:

GoogleCodeExporter commented 9 years ago
Is this still a problem?

Original comment by thestig@chromium.org on 18 Dec 2013 at 2:18

GoogleCodeExporter commented 9 years ago
I doubt it. This was due to a compiler bug in GCC 4.4.3 which is now obsolete. 
Current NDK releases provide 4.6 instead, with a planned move to 4.8 :-)

Original comment by di...@google.com on 18 Dec 2013 at 6:58

GoogleCodeExporter commented 9 years ago
WontFix unless we hear otherwise.

Original comment by thestig@chromium.org on 18 Dec 2013 at 7:36