search

dimastbk / python-calamine

Python binding for Rust's library for reading excel and odf file - calamine.
https://pypi.org/project/python-calamine/
MIT License
279 stars 6 forks source link

No way to close a CalamineWorkbook? #91

Closed RedAero closed 1 week ago

RedAero commented 2 weeks ago

There is no .close() method and as far as I can tell a with block has no effect either. Can these features please be implemented so the file being read doesn't remain locked until the executing program closes?

dimastbk commented 2 weeks ago

Hi. Could you give a reproducible example?

RedAero commented 2 weeks ago

A reproducible example of a missing feature?

Sure. Create a CalamineWorkbook then try to close it.

dimastbk commented 1 week ago

Released in 0.3.0. But close only prevents the fd from leaking and frees resources, and doesn't unlock the file, because of the file has never been locked before (at least on linux).