search

dimensional-de / napi-canon-cameras

Node AddOn Api module for Canon cameras
GNU General Public License v3.0
51 stars 18 forks source link

add EVF zoom data #11

Closed RedSparrowEU closed 1 year ago

RedSparrowEU commented 1 year ago

Hello, a little quick upgrade that could probably be done even better. However, as a prototype it seems to work fine. Since the zoom data is in evfImage, it seems reasonable to have it all in one place with the download of the live view image. A neater approach if it were done as an object.... In any case, I think as a starting point is sufficient.

Thanks, Greg

ThomasWeinert commented 1 year ago

I think the return value needs to be replaced with an object - like the CameraFile. I will try to refactor your suggestion.

Here is a new issue for this task: https://github.com/dimensional-de/napi-canon-cameras/issues/12