search

dimensional-de / napi-canon-cameras

Node AddOn Api module for Canon cameras
GNU General Public License v3.0
51 stars 18 forks source link

MacOS support and EVF Zoom #7

Open RedSparrowEU opened 1 year ago

RedSparrowEU commented 1 year ago

Hi,

First of all - great job! The code is like a work of art. Outstanding! On Windows, compilation and installation was a pleasure. So rarely I have had the opportunity to observe so silky smooth process. The examples show that everything works as it should. Camera connects, taking pictures, processing live view... I also tried on MacOS (10.14 and 10.15). Well, and again - even this platform was considered as a target - great! The installation process was less smooth and required a few extra steps, but it worked! However, during startup, the program got stuck, I presume, on linking EDSDK framework or init process.... hard to say more... in any case, the question is, did you successfully use the MacOS version of your libs? Second question, are you planning to add EVF zoom data (rectangle/position)?

Used tech: Build - Node 16.15.0 (win) / 16.14.2 (mac), Runtime - Electron 20.0.2

Thanks again! Greg

ThomasWeinert commented 1 year ago

Thanks,

I tried to adapt the changes from https://github.com/Olliebrown/napi-canon-cameras/commit/9b3ce203b04c0a9642d3520359824bb320b59ff7 for Mac support.

I don't have a Mac, so I can not help with it directly. However I am happy to merge the required changes.

Best Regards Thomas

Olliebrown commented 1 year ago

@RedSparrowEU I attempted to get the Mac version of this library working once and it did eventually build for me but it was not a high priority so I never got around to testing it or confirming functionality. Our primary application is with Windows computers so our effort has been focused there. I MIGHT be able to revive that effort later but it's a very big maybe. I am quite out of my element here (with the NAPI and wrapping Mac OS libraries) but I can hack at it a bit in my spare time.

I'll post here if I end up reviving anything and getting it tested/working.

RedSparrowEU commented 1 year ago

@Olliebrown Some hot news about MacOS version? ;) Tried the mentioned branch, but without luck...