ForLabel in aperture & shutter-speed sometimes returns inaccurate data for values affected by Custom Function (marked with '1/3')

dimensional-de / napi-canon-cameras

Node AddOn Api module for Canon cameras

GNU General Public License v3.0

59 stars 22 forks source link

ForLabel in aperture & shutter-speed sometimes returns inaccurate data for values affected by Custom Function (marked with '1/3') #9

Closed SamsonSmithC closed 1 year ago

SamsonSmithC commented 2 years ago

The ForLabel function in aperture.cc & shutter-speed.cc returns the first value that matches the label. Entries affected by the 'Exposure Level Increment' custom function all have 2 values mapped to the same label in no particular order. The means switching the Exposure Level Increment between 1/2 and 1/3, won't solve the issue, just change which values are wrong. Some values returned by this function will always be incorrect unless it references the camera's Exposure Level Increment to choose between the duplicate mappings.

Exposure Level Increment: Property ID: 9 Specifier: 257 Values:

0: (1/3-stop)
1: (1/2-stop)

ThomasWeinert commented 2 years ago

https://github.com/dimensional-de/napi-canon-cameras/commit/4566f27cdbcabb3508b38bf9f0a3b59049da86e9

Split value lists
forLabel() support (1/3) suffix
label includes (1/3) suffix
Added property stop
Added unit tests:
- https://github.com/dimensional-de/napi-canon-cameras/blob/4566f27cdbcabb3508b38bf9f0a3b59049da86e9/tests/common/Aperture.test.ts#L56
- https://github.com/dimensional-de/napi-canon-cameras/blob/4566f27cdbcabb3508b38bf9f0a3b59049da86e9/tests/common/ShutterSpeed.test.ts#L67