search

dimer47 / node-ovh-objectstorage

Creative Commons Attribution Share Alike 4.0 International
12 stars 11 forks source link

Rename "save" function to "saveFile", add "saveData" function and add alias "save" to "saveFile" #13

Closed Relik77 closed 4 years ago

Relik77 commented 4 years ago

Rename "save" function to "saveFile" : takes the path of a file as a parameter Add alias for "saveFile" : "save" (To be compatible with older code) (deprecated)

Add "saveData" function : takes the content of a file as a parameter

dimer47 commented 4 years ago

Hi @Relik77,

I agree with @Mattia-Longhin this is a new feature. You have a great idea to implement this method ! Thank you again for you contribution. But it's possible to re-submite a new PR excluding encoding change on get() method ?

For this other subject, I propose to you an alternative on issue, I wait your opinion. On open a new PR excluding encoding, I accept you PR to merge changes.